Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Jun 7, 2025

Fix the default value so that the generated JSON schema is correct and autocomplete works as expected.

Before this PR:

image

After:

Screenshot 2025-06-17 at 12 54 45
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: tested locally
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not affected
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: schema update
  • Wrangler V3 Backport

@vicb vicb requested a review from a team as a code owner June 7, 2025 07:22
@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2025

🦋 Changeset detected

Latest commit: 884e0c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 7, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9520

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9520

miniflare

npm i https://pkg.pr.new/miniflare@9520

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9520

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9520

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9520

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9520

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9520

wrangler

npm i https://pkg.pr.new/wrangler@9520

commit: 884e0c5

@vicb vicb force-pushed the vicb/keep_names branch from c6fa167 to b84c3df Compare June 7, 2025 07:24
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main vicb/keep_names might be a good starting point.

@vicb vicb force-pushed the vicb/keep_names branch from b84c3df to 5e41bee Compare June 7, 2025 07:26
@vicb vicb added wrangler Relating to the Wrangler CLI tool skip-v3-pr Skip validation of presence of a v3 backport PR labels Jun 7, 2025
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang it! I must have copy-pasted the thing wrongly! 😓

Thanks for fixing it Vic 🫶

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 7, 2025
@vicb vicb force-pushed the vicb/keep_names branch from 5e41bee to fe03be4 Compare June 11, 2025 06:58
@vicb vicb added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit 04f9164 Jun 12, 2025
24 of 25 checks passed
@vicb vicb deleted the vicb/keep_names branch June 12, 2025 13:53
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR wrangler Relating to the Wrangler CLI tool

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants