Skip to content

Support image name without account ID #9813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

Support image name without account ID #9813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87aca00
Support image name without account ID
gpanders Jul 1, 2025
7049bc0
Merge branch 'main' into push-oxmlnmluomut
gpanders Jul 3, 2025
a65d3bc
Skip containers E2E tests when no auth available
gpanders Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fruity-pillows-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Support container image names without account ID
5 changes: 4 additions & 1 deletion packages/wrangler/e2e/containers.dev.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ const imageSource = ["pull", "build"];
// We can only really run these tests on Linux, because we build our images for linux/amd64,
// and github runners don't really support container virtualization in any sane way
describe
.skipIf(process.platform !== "linux" && process.env.CI === "true")
.skipIf(
!CLOUDFLARE_ACCOUNT_ID ||
(process.platform !== "linux" && process.env.CI === "true")
)
.each(imageSource)(
"containers local dev tests: %s",
{ timeout: 90_000 },
Expand Down
Loading
Loading