feat: ✨ added new DEPLOYMENT_ENVIRONMENT input param for the action #355
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoloshchenkoAl
force-pushed
the
feat/add-deployment-name
branch
from
63e97e2 to
f940b70
Compare
Maximo-Guk
reviewed
Feb 19, 2025
jrencz
reviewed
Mar 9, 2025
VoloshchenkoAl
force-pushed
the
feat/add-deployment-name
branch
from
f940b70 to
77deadf
Compare
VoloshchenkoAl
changed the title
jrencz
approved these changes
Apr 10, 2025
jrencz
left a comment
jrencz
left a comment
There was a problem hiding this comment.
Thanks for the adjustment. Now it's just right
|
Amazing feature, would be nice to get it merged. My use case is the frontend deployed via Pages to dev and prod workers. Both of them have GitHub deployments with the title 'production', which is confusing |
1 task
|
@Maximo-Guk can we get this merged please?👍 |
|
Any update from maintainers on getting this merged? I have three sites in a monorepo and quickly getting the preview URLs for each site if they all get updated is slightly annoying :( |
|
+1 vote for this getting merged. Would be a very useful feature, thanks @VoloshchenkoAl for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
DEPLOYMENT_NAMEinput parameter was added for the action. This param is responsible for the custom name of the GitHub DeploymentWhy are these changes added?
I have a monorepo with several static sites, that I deploy to the Cloudflare Pages. When I create a Preview for them all, they have the same name —
preview, and only the last deployed Site is available through the Deployment panel.With the changes from this PR, I could:
View words about the previous action
The
pages-actionhas another solution for the problem. I think that the input parameter is a better solution because gives more flexibility for naming