Skip to content

getSelectedModels does not break models' order #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rcandea wants to merge 1 commit into
base: master
Choose a base branch
from
Open

getSelectedModels does not break models' order #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions backgrid-select-all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,12 @@
if (selectAllHeaderCell) {
var selectedModels = selectAllHeaderCell.selectedModels;
var collection = this.collection.fullCollection || this.collection;
for (var modelId in selectedModels) {
result.push(collection.get(modelId));
}
collection.each(function (model) {
var key = model.id || model.cid;
if (_.has(selectedModels, key)) {
result.push(model);
}
});
}

return result;
Expand Down
15 changes: 8 additions & 7 deletions test/select-all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ describe("Grid#getSelectedModels", function () {
});

it("will return a list of selected models", function () {
var collection = new Backbone.Collection([{id: 1}, {id: 2}]);
var collection = new Backbone.Collection([{id: 1}, {id: 3}, {id: 2}]);

var grid = new Backgrid.Grid({
collection: collection,
Expand All @@ -395,18 +395,19 @@ describe("Grid#getSelectedModels", function () {
});

var selectedModels = grid.getSelectedModels();
expect(selectedModels.length).toBe(2);
expect(selectedModels.length).toBe(3);
expect(selectedModels[0].id).toBe(1);
expect(selectedModels[1].id).toBe(2);
expect(selectedModels[1].id).toBe(3);
expect(selectedModels[2].id).toBe(2);
});

it("will return a list of selected models across pageable pages", function(){
var pageable = new Backbone.PageableCollection([{id:1}, {id:2}, {id:3}], {
var pageable = new Backbone.PageableCollection([{id:1}, {id:3}, {id:2}], {
state: { pageSize: 2 },
mode: "client"
});
var one = pageable.get(1);
var three = pageable.fullCollection.get(3);
var two = pageable.fullCollection.get(3);

var grid = new Backgrid.Grid({
collection: pageable,
Expand All @@ -424,13 +425,13 @@ describe("Grid#getSelectedModels", function () {

one.trigger("backgrid:selected", one, true);
pageable.getLastPage();
three.trigger("backgrid:selected", three, true);
two.trigger("backgrid:selected", two, true);

var selectedModels = grid.getSelectedModels();

expect(selectedModels.length).toBe(2);
expect(selectedModels[0]).toBe(one);
expect(selectedModels[1]).toBe(three);
expect(selectedModels[1]).toBe(two);
});

});
Expand Down