This repository was archived by the owner on Jun 8, 2023. It is now read-only.
Add ENV_IGNORE_TLS_CERTIFICATE option#18
Open
serbanc-ppb wants to merge 1 commit intocloudflarearchive:masterfrom
Open
Add ENV_IGNORE_TLS_CERTIFICATE option#18serbanc-ppb wants to merge 1 commit intocloudflarearchive:masterfrom
serbanc-ppb wants to merge 1 commit intocloudflarearchive:masterfrom
Conversation
Allow posibility to ignore server side certificates when connecting to ElasticSearch
fholzer
reviewed
Dec 22, 2020
| if (System.getenv(ENV_AWS_ACCESS_KEY) != null && System.getenv(ENV_AWS_SECRET_KEY) != null) { | ||
| USE_AWS_CREDENTIALS = true; | ||
| } | ||
| if (System.getenv(ENV_IGNORE_TLS_CERTIFICATE) != null && System.getenv(ENV_IGNORE_TLS_CERTIFICATE) != null) { |
There was a problem hiding this comment.
why is System.getenv(ENV_IGNORE_TLS_CERTIFICATE) checked twice here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow posibility to ignore server side certificates when connecting to ElasticSearch