Skip to content

fix: delete wrong data type #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: delete wrong data type #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/spaceone/inventory/connector/aws_cloud_watch_connector/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ def _set_alarm_history(self, raw_alarm: Alarms) -> None:

alarm_histories = self.get_alarm_history(raw_alarm["AlarmName"])
for alarm_history in alarm_histories:
print(alarm_history["Timestamp"])
history.append(
{
"date": alarm_history["Timestamp"],
Expand Down
7 changes: 3 additions & 4 deletions src/spaceone/inventory/connector/aws_cloud_watch_connector/schema/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import logging

from schematics import Model
from schematics.types import StringType, ModelType, ListType
from schematics.types import StringType, ModelType, ListType, DateTimeType

from spaceone.inventory.libs.schema.dynamic_field import DateTimeDyField
from spaceone.inventory.libs.schema.resource import AWSCloudService

_LOGGER = logging.getLogger(__name__)
Expand All @@ -19,7 +18,7 @@ class Action(Model):


class History(Model):
date = DateTimeDyField(deserialize_from="date")
date = DateTimeType(deserialize_from="date")
type = StringType(choices=("ConfigurationUpdate","StateUpdate","Action"), deserialize_from="type")
description = StringType(deserialize_from="description")

Expand All @@ -28,7 +27,7 @@ class Alarms(AWSCloudService):
alarm_arn = StringType(deserialize_from="AlarmArn")
name = StringType(deserialize_from="AlarmName")
state_value = StringType(choices=("OK","ALARM","INSUFFICIENT_DATA"), deserialize_from="StateValue")
state_updated_timestamp = DateTimeDyField(deserialize_from="StateUpdatedTimestamp")
state_updated_timestamp = DateTimeType(deserialize_from="StateUpdatedTimestamp")
actions_enabled = StringType(deserialize_from="actions_enabled")
conditions = StringType(deserialize_from="conditions")
actions = ListType(ModelType(Action, deserialize_from="action"), deserialize_from="actions")
Expand Down
Loading