Skip to content

fix: fix elb typo #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

fix: fix elb typo #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99f567c
fix: fix elb typo
jinyoungmoonDEV Apr 22, 2025
63a8930
fix: fix elb typo
jinyoungmoonDEV Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/spaceone/inventory/connector/aws_elb_connector/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,23 +307,23 @@ def get_formatted_conditions(raw_conditions: list, is_default: bool) -> list:
header_values: list = config.get("Values")

if header_name and header_values:
str_value = ",".join(header_values)
str_value = ','.join(header_values)
str_conditions.append("HTTP Header :")
str_conditions.append(f" - {header_name} : {str_value}")

elif field == "http-request-method":
if values := condition.get("HttpRequestMethodConfig", {}).get("Values"):
str_value = ",".join(values)
str_value = ','.join(values)
str_conditions.append(f"HTTP Request Method : {str_value}")

elif field == "host-header":
if values := condition.get("HostHeaderConfig", {}).get("Values"):
str_value = ",".join(values)
str_value = ','.join(values)
str_conditions.append(f"Host Header : {str_value}")

elif field == "path-pattern":
if values := condition.get("PathPatternConfig", {}).get("Values"):
str_value = ",".join(values)
str_value = ','.join(values)
str_conditions.append(f"Path Pattern : {str_value}")

elif field == "query-string":
Expand All @@ -341,7 +341,7 @@ def get_formatted_conditions(raw_conditions: list, is_default: bool) -> list:

elif field == "source-ip":
if values := condition.get("SourceIpConfig", {}).get("Values"):
str_value = ",".join(values)
str_value = ','.join(values)
str_conditions.append(f"Source IP : {str_value}")

return str_conditions
Expand Down
6 changes: 1 addition & 5 deletions src/spaceone/inventory/connector/aws_elb_connector/schema/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,7 @@
),
TextDyField.data_source("Port", "port"),
TextDyField.data_source("Priority", "priority"),
ListDyField.data_source(
"Conditions",
"conditions",
default_badge={"type": "outline", "delimiter": "<br>"},
),
ListDyField.data_source("Conditions", "conditions"),
ListDyField.data_source("Actions", "actions"),
TextDyField.data_source("Rule Arn", "rule_arn"),
],
Expand Down
Loading