Skip to content

fix: fix vulnerable_ports optional logic to background #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: fix vulnerable_ports optional logic to background #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/plugin/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,17 +314,5 @@ def _create_init_metadata():
"inventory.Region",
"inventory.ErrorResource",
],
"options_schema": {
"required": ["vulnerable_ports"],
"type": "object",
"properties": {
"vulnerable_ports": {
"title": "Vulnerable Ports Option",
"type": "string",
"default": DEFAULT_VULNERABLE_PORTS,
"description": "Ex) 22,8080,3306 (Default = 22,3306)",
}
},
},
}
}
17 changes: 9 additions & 8 deletions src/plugin/manager/ec2/security_group_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def create_cloud_service(self, region, options, secret_data, schema):
cloudtrail_resource_type = "AWS::EC2::SecurityGroup"

# If Port Filter Option Exist
vulnerable_ports = options.get("vulnerable_ports", DEFAULT_VULNERABLE_PORTS)
vulnerable_ports = options.get("vulnerable_ports")

# Get default VPC
default_vpcs = self._get_default_vpc()
Expand Down Expand Up @@ -173,14 +173,15 @@ def custom_security_group_inbound_rule_info(self, raw_rule, remote, remote_type,

protocol_display = raw_rule.get("protocol_display")

ports = self._get_vulnerable_ports(protocol_display, raw_rule, vulnerable_ports)
if vulnerable_ports:
ports = self._get_vulnerable_ports(protocol_display, raw_rule, vulnerable_ports)

raw_rule.update(
{
"vulnerable_ports": ports,
"detected_vulnerable_ports": True if ports else False
}
)
raw_rule.update(
{
"vulnerable_ports": ports,
"detected_vulnerable_ports": True if ports else False
}
)

return raw_rule

Expand Down
Loading