Skip to content

Conversation

gmllt
Copy link
Collaborator

@gmllt gmllt commented May 3, 2025

No description provided.

@gmllt gmllt requested a review from Copilot May 3, 2025 08:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Cloud Foundry CLI dependency to v8.13.0 by updating API calls to align with the new version. Key changes include replacing calls to GetInfo() with GetRoot() and updating all subsequent references from info to root.

Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

session.go:143

  • [nitpick] Consider updating the error message to correct the grammatical error by replacing 'informations' with 'information' for clarity.
return fmt.Errorf("could not fetch api root informations: %s", err)

@gmllt gmllt force-pushed the bump-to-cloudfoundry-cli-v8-13-0 branch from 67015c1 to 0b0b895 Compare May 3, 2025 08:38
@gmllt gmllt requested a review from Copilot May 3, 2025 08:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version of code.cloudfoundry.org/cli to v8.13.0 and updates API endpoint usage in the session handling.

  • Replace GetInfo() calls with GetRoot()
  • Update subsequent method calls and error messages accordingly
Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (2)

session.go:153

  • [nitpick] Consider refining the error message 'error setup resource uaa: %s' to a more grammatically consistent version such as 'error setting up UAA resources: %s'.
err = uaaClient.SetupResources(root.UAA(), root.Login())

session.go:203

  • [nitpick] Consider refining the error message 'error setup resource uaa: %s' to a more grammatically consistent version such as 'error setting up UAA resources: %s'.
err = uaaClientSess.SetupResources(root.UAA(), root.Login())

@gmllt gmllt merged commit 58e4838 into master May 3, 2025
4 checks passed
@gmllt gmllt deleted the bump-to-cloudfoundry-cli-v8-13-0 branch May 3, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant