Fix non http promtail config add spec tests #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaumsap
force-pushed
the
fix-non-http-promtail-config-add-spec-tests
branch
from
8f1c16c to
635fff0
Compare
Start with promtail config file for now. Based on https://github.com/cloudfoundry/otel-collector-release
jbaumsap
force-pushed
the
fix-non-http-promtail-config-add-spec-tests
branch
from
635fff0 to
cc0e133
Compare
jbaumsap
commented
Jun 23, 2025
| - uses: actions/checkout@v4 | ||
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.4' |
Author
There was a problem hiding this comment.
Not sure if its OK to use newer version here?
Author
|
Closing in favor of #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly fixes a minor typo.
While I was at it I also added some tests and GitHub workflow for it based on
https://github.com/cloudfoundry/otel-collector-release
Only the two properties of the promtail config file are being tested for now.