Skip to content

Conversation

@joergdw
Copy link
Contributor

@joergdw joergdw commented Apr 24, 2025

Brings in following fixes:

  • Adapt targets called from the pipeline to the changes in Makefiles as part of PR Clean-up Makefiles #3687. And includes some fixes.
  • Auto-login to the os-concourse-instance if the required concourse-target via concourse login has not been defined already.
  • Refactoring of the login across Makefile and devbox-hook.

@joergdw joergdw force-pushed the pipeline-fixes branch 3 times, most recently from 9f36122 to 513f85e Compare May 8, 2025 06:47
@joergdw joergdw mentioned this pull request May 8, 2025
@joergdw joergdw marked this pull request as ready for review May 8, 2025 09:27
Copy link
Contributor

@bonzofenix bonzofenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asalan316
Copy link
Contributor

we also need to bring back the make target build-test as the it will probably fail the make-bosh-prerelease concourse task

@joergdw joergdw mentioned this pull request May 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2025

@joergdw joergdw merged commit 4929a33 into main May 9, 2025
35 checks passed
@joergdw joergdw deleted the pipeline-fixes branch May 9, 2025 07:55
joergdw added a commit that referenced this pull request May 9, 2025
This reverts commit 4929a33, reversing
changes made to 70d8b49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants