(feature): Enable ScalingEngine in mtar deployment #3797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update eventgenerator configuration to use pointers for optional structs and add JSON tags - Modify eventgenerator test suite to handle CF environment variables and dynamically set config - Adjust eventgenerator main.go to load and validate config with VCAP services support - Implement ToJSON method in config.go for marshaling configuration to JSON - Change environment variable keys in mta.tpl.yaml to uppercase and use placeholders for Go version
• Introduce eventgenerator_health_password in build-extension-file.sh for event generator health checks. • Add eventgenerator-config resource with basic auth password in mta.tpl.yaml. • Implement configureMetricsCollectorTLS function in eventgenerator/config/config.go to load TLS configuration for the metrics collector from logcache-client. • Update eventgenerator unit tests to reflect new TLS configuration loading. • Remove scaling engine and metric collector TLS configs from default_config.json, streamline cf_server and db configurations. • Add logcache-client as a user-provided service in mta.tpl.yaml.
…e-cf-services.yml
- Introduce pool configuration to manage eventgenerator node count and index - Remove commented-out XFCC and route registration configurations - Implement instance index and space/org GUID retrieval in configutil - Adjust eventgenerator main.go to use new pool configuration - Update tests and default JSON config to reflect changes
…and XFCC header setting
…toscaler extension build script
… in autoscaler extension build script.
…ting Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…caler build script
… components • Eliminate syslog-client requirement from metricsforwarder module and related resources • Remove logcache-client dependency from eventgenerator and metricsforwarder modules • Delete configuration code for Metrics Collector TLS setup in eventgenerator
…nProcessorTest • Add support for client certificate and key in VCAP services • Prioritize sslcert over client_cert when both are present • Ensure proper credential mapping for database services
…lignments in tt push est cases
…tting check in CI script
bonzofenix
force-pushed
the
885-enable-scalingengine-via-mtar
branch
from
028ae79 to
cb177b1
Compare
…undry components • Update deploy-multiapps-controller.sh to deploy with 4G memory limit • Add 500GB_ephemeral_disk vm_extension to diego-cell in scale_out_cf_for_app-autoscaler.yaml • Set maximum_app_disk_in_mb to 4096 for cc-worker and api instance groups in Cloud Foundry configuration
…akefile - Introduce dynamic version assignment using PR_NUMBER for mta-deploy in deploy-apps.sh - Update Makefile to use MTAR_FILENAME variable during cf deploy command
asalan316
reviewed
Jun 30, 2025
asalan316
reviewed
Jun 30, 2025
asalan316
approved these changes
Jun 30, 2025
…gingLevel • Implement SetLoggingLevel method across multiple config structs to standardize logging level setting. • Refactor LoadConfig functions to utilize GenericLoadConfig for a more generic approach to loading configurations. • Change loadVcapConfig functions to LoadVcapConfig and adjust visibility to align with the new generic config loading pattern. • Introduce Configurable and VCAPConfigurable interfaces along with VCAPConfigurableFunc to facilitate the new generic loading mechanism.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces multiple changes across scripts, configuration files, and Makefiles to enhance scaling engine support, optimize resource allocation, and streamline configurations. Key updates include adding scaling engine modules and configurations, improving resource definitions, and modifying deployment scripts to accommodate larger memory and disk allocations.
Scaling Engine Support Enhancements:
build-extension-file.sh, including routes, health checks, and CF client credentials. [1] [2]Resource Allocation Optimization:
deploy-multiapps-controller.shandscale_out_cf_for_app-autoscaler.yaml. [1] [2]Configuration Improvements:
configutilto add error handling for missing service configurations and support YAML parsing.config.go. [1] [2]Codebase Cleanup:
use-cf-services.yml..gitignoreand Makefile targets to streamline build processes and ignore unnecessary files. [1] [2]These changes collectively enhance scalability, maintainability, and resource efficiency within the autoscaler project.