Preperational refactoring #3886
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation for the clean-parser;
👎 Access to `details.AppGUID` has been deprecated, see: <https://github.com/openservicebrokerapi/servicebroker/blob/v2.17/spec.md#request-creating-a-service-binding>
1. Fix errors in newly introduced, safer types for the parameters of a binding-request; 2. Spread usage of those types; 3. Adapt tests 4. Warning hint for making use of the default-constructor for certain types. (Zero-Value Problem)
Still to come: „BindingConfig“ and „AppScalingConfig“
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring is in preparation for service-key-inclusion in #3652. In particular it makes some internal APIs safer and provides some bug-fixes.
Apart from this it introduces more json-schema-descriptions (still without using them) that are compatible with the old ones.