Add support for extracting xattrs on unix #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When extended file attributes are set on a file in the archive, try to preserve them on extraction but do not fail when the user does not have permission to set them or if they are not supported. This should prevent existing usages from breaking while also enabling users to preserve extended file attributes.
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
Contributor
|
Thanks @maxmoehl for this PR. It looks good to me. Can you comment on whether it's possible to add a test coverage for this or not ? |
Member
Author
|
The main issue is that writing file capabilities requires the I don't think we want to require |
github-project-automation
bot
moved this from Inbox
to Done
in Application Runtime Platform Working Group
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When extended file attributes are set on a file in the archive, try to preserve them on extraction but do not fail when the user does not have permission to set them or if they are not supported. This should prevent existing usages from breaking while also enabling users to preserve extended file attributes.
Part of cloudfoundry/diego-release#1092
Backward Compatibility
Breaking Change? No