Merged
Conversation
Adds exceptions in some cases.
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
rkoster
requested review from
a team and
klakin-pivotal
and removed request for
a team
rkoster
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
xtreme-nitin-ravindran
approved these changes
Mar 6, 2025
github-project-automation
bot
moved this from Pending Review | Discussion
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
selzoc
approved these changes
Mar 7, 2025
Member
selzoc
left a comment
selzoc
left a comment
There was a problem hiding this comment.
LGTM, some questions just about the results of the linters.
|
|
||
| func (r *cmdRunner) RunStreamingCommand(out io.Writer, env map[string]string, args ...string) (string, string, int, error) { | ||
| exports := make([]string, len(env)) | ||
| var exports []string |
Member
There was a problem hiding this comment.
What's wrong with makeing a slice if you know the length beforehand?
Author
There was a problem hiding this comment.
Nothing wrong, but you'd want to index the slice to add items instead of append like below. append is going to grow the slice and then you have len(env) zero-values at the beginning of the slice.
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds exceptions in some cases.
Linters not enabled need to be fixed at a later time after examining changes.