Move the stemcell acceptance specs to top-level #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the go module dependency management tooling Golang source code needed to be in a repository-relative path under `src/`, this is no longer true. This commit moves `src/github.com/cloudfoundry/stemcell-acceptance-tests/` to the top-level of the repo, renaming the folder to `acceptance-tests/`. The golang packages are updated to reflect this. In addition the `tools` package is removed since Ginkgo v2 no longer requires this to ensure the CLI code is available when testing.
This change should make the script runnable from any location
Member
Author
|
The following should also be merged: |
aramprice
requested review from
a team,
bgandon and
xtreme-nitin-ravindran
and removed request for
a team
Member
Author
|
Searched for consumers via the following query |
Contributor
|
looks good to me as stated in #411 if we are going that route |
ramonskie
approved these changes
Jan 25, 2025
This was referenced Jan 30, 2025
Contributor
|
We can merge this forward to the Noble branch after it's been merged that way we avoid a second PR |
jpalermo
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the go module dependency management tooling Golang source code needed to be in a repository-relative path under
src/, this is no longer true. This commit movessrc/github.com/cloudfoundry/stemcell-acceptance-tests/to the top-level of the repo, renaming the folder toacceptance-tests/. The golang packages are updated to reflect this.In addition the
toolspackage is removed since Ginkgo v2 no longer requires this to ensure the CLI code is available when testing.