Add IsNonCompressedTarball method to Compressor interface #128
Closed
mdzhigarov wants to merge 5 commits intocloudfoundry:developfrom
Closed
Add IsNonCompressedTarball method to Compressor interface #128mdzhigarov wants to merge 5 commits intocloudfoundry:developfrom
mdzhigarov wants to merge 5 commits intocloudfoundry:developfrom
Conversation
- Add IsNonCompressedTarball method to Compressor interface - Implement IsNonCompressedTarball in tarballCompressor using 'file' command - Implement IsNonCompressedTarball in FakeCompressor returning false - Add comprehensive unit tests for IsNonCompressedTarball functionality - Tests cover positive/negative cases, error handling, and edge cases
This reverts commit 11f69ae.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
IsNonCompressedTarballto theCompressorinterface to detect whether a file is a non-compressed tarball.Changes
IsNonCompressedTarball(path string) (bool, error)method to theCompressorinterfacetarballCompressorusing the native golang approach to inspect the tar contentsFakeCompressorreturningfalsefor testing purposesTesting
All existing tests pass and new unit tests provide comprehensive coverage of the new functionality.