[337] Add logic to run child processes nicer than parent#133
Open
ionphractal wants to merge 8 commits intocloudfoundry:developfrom
Open
[337] Add logic to run child processes nicer than parent#133ionphractal wants to merge 8 commits intocloudfoundry:developfrom
ionphractal wants to merge 8 commits intocloudfoundry:developfrom
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
|
Thanks for picking this back up. With regards to testing, given that all logic sits in an external library, it would be best to only add an integration test which would write out a bash script in a temporary file and execute it once without the flag and once with the flag. The bash script could echo its own nice level. |
beyhan
requested review from
a team,
Alphasite and
s4heid
and removed request for
a team
beyhan
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
rkoster
moved this from Pending Review | Discussion
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
Alphasite
reviewed
Dec 31, 2025
Member
|
@ionphractal - are you still working on this or shall we close it? |
Author
yes, will rename it. I'm sorry, I got a lot going on lately... |
Member
|
@ionphractal we converted this one to draft to not having it on our project board but we will take it again in when it is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to cloudfoundry/bosh-agent#337 but the logic resides in bosh-utils.
@rkoster
I would still need help with how to write the tests. What would need to be done?
Btw adding it to the bosh-agent would then just look like this? https://github.com/cloudfoundry/bosh-agent/compare/main...ionphractal:bosh-agent:337-nice-child-scripts?expand=1