Merged
Conversation
Add tests that enable features and bind services via manifest; keep tests that use the API instead. Test 'file-based-vcap-services' and 'service-binding-k8s' features for buildpack, cnb and docker apps. Refactor test setup; the three lifecycles need different args for 'create-app' and 'push', otherwise operations are identical. Also enhance test validation; read VCAP_SERVICES_FILE_PATH and SERVICE_BINDING_ROOT env vars from app.
philippthun
force-pushed
the
features-in-manifest
branch
from
e8b5526 to
c362041
Compare
jochenehret
reviewed
Jun 30, 2025
ssh/ssh.go
Outdated
| It("can be disabled via cli", func() { | ||
| Expect(cf.Cf("disable-ssh", appName).Wait()).To(Exit(0)) | ||
|
|
||
| sshCmd := cf.Cf("ssh", "-v", appName) |
Contributor
There was a problem hiding this comment.
This code block is used 4 times, could it be extracted?
Member
Author
There was a problem hiding this comment.
I've extracted it - twice. There does not seem to be a pattern how to reuse stuff in the windows suite...
Add tests that disable ssh via cli command and manifest. Also as part of Windows tests.
philippthun
force-pushed
the
features-in-manifest
branch
from
c362041 to
909e81d
Compare
jochenehret
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
Test app features specified in the manifest.
Please provide contextual information.
cloudfoundry/cloud_controller_ng#4358
What version of cf-deployment have you run this cf-acceptance-test change against?
v49
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
What is the level of urgency for publishing this change?