Skip to content

chore: use Go 1.24 tool feature for Ginkgo #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blgm merged 3 commits into from
Feb 13, 2025
Merged

chore: use Go 1.24 tool feature for Ginkgo #1188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9b0e6d
chore: use Go 1.24 tool feature for Ginkgo
blgm Feb 12, 2025
47a279e
Merge branch 'main' into gotool
blgm Feb 12, 2025
48448c1
Merge branch 'main' into gotool
blgm Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/focused-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ jobs:
with:
go-version: '1.24.0'
- uses: actions/checkout@v4
- run: go run github.com/onsi/ginkgo/v2/ginkgo unfocus && test -z "$(git status -s)"
- run: go tool ginkgo unfocus && test -z "$(git status -s)"

2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ test-units: ## run unit tests
# Integration tests are relatively resource-hungry, so we tune down the number of processes that run in parallel
.PHONY: test-integration
test-integration: .pak-cache ## run integration tests
PAK_BUILD_CACHE_PATH=$(PAK_CACHE) go run github.com/onsi/ginkgo/v2/ginkgo --procs 4 integrationtest/...
PAK_BUILD_CACHE_PATH=$(PAK_CACHE) go tool ginkgo --procs 4 integrationtest/...

.pak-cache:
mkdir -p $(PAK_CACHE)
Expand Down
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,3 +142,5 @@ require (
gopkg.in/ini.v1 v1.67.0 // indirect
rsc.io/goversion v1.2.0 // indirect
)

tool github.com/onsi/ginkgo/v2/ginkgo
1 change: 0 additions & 1 deletion tools/tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package tools
import (
_ "github.com/google/gops"
_ "github.com/maxbrunsfeld/counterfeiter/v6"
_ "github.com/onsi/ginkgo/v2/ginkgo"
_ "golang.org/x/tools/cmd/goimports"
_ "honnef.co/go/tools/cmd/staticcheck"
)
Expand Down