fix: Fix printf format verbs in test files#1389
Merged
georgidimdimitrov merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
The go vet printf analyzer flagged two test files for using %q with non-string types, causing CI failures on all open PRs: - varcontext_test.go: %q used for int values, changed to %d - fetch_test.go: %q used for getter.ClientMode values, changed to %v Also fixed the error message to say "Mode" instead of "Dst". ai-assisted=yes Made-with: Cursor
georgidimdimitrov
changed the title
bogomil-kuzmanov
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
All 6 open dependabot PRs (#1383, #1384, #1385, #1386, #1387, #1388) are failing with the same two go vet errors:
These are pre-existing issues on main that block all PRs from merging. Once this fix lands, re-running CI on those PRs should make them pass.
Test plan