Skip to content

Commit 29cc9de

Browse files
committed
Add telemetry data for usage of deployment web
Fix Rubocop errors
1 parent 3e10537 commit 29cc9de

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

app/actions/deployment_create.rb

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ def create(app:, user_audit_info:, message:)
2525

2626
if target_state.rollback_target_revision
2727
revision = RevisionResolver.rollback_app_revision(app, target_state.rollback_target_revision, user_audit_info)
28-
log_rollback_event(app.guid, user_audit_info.user_guid, target_state.rollback_target_revision.guid, message.strategy, message.max_in_flight, message.canary_steps,
29-
message.web_instances, message.memory_in_mb, message.disk_in_mb, message.log_rate_limit_in_bytes_per_second)
28+
log_rollback_event(app.guid, user_audit_info.user_guid, target_state.rollback_target_revision.guid, message)
3029
else
3130
revision = RevisionResolver.update_app_revision(app, user_audit_info)
3231
end
@@ -271,7 +270,7 @@ def starting_process_instances(deployment, desired_instances)
271270
[deployment.max_in_flight, starting_process_count].min
272271
end
273272

274-
def log_rollback_event(app_guid, user_id, revision_id, strategy, max_in_flight, canary_steps, instances, memory, disk, log_rate)
273+
def log_rollback_event(app_guid, user_id, revision_id, message)
275274
TelemetryLogger.v3_emit(
276275
'rolled-back-app',
277276
{
@@ -280,13 +279,13 @@ def log_rollback_event(app_guid, user_id, revision_id, strategy, max_in_flight,
280279
'revision-id' => revision_id
281280
},
282281
{
283-
'strategy' => strategy,
284-
'max-in-flight' => max_in_flight,
285-
'canary-steps' => canary_steps,
286-
'instances' => instances,
287-
'memory' => memory,
288-
'disk' => disk,
289-
'log-rate' => log_rate
282+
'strategy' => message.strategy,
283+
'max-in-flight' => message.max_in_flight,
284+
'canary-steps' => message.canary_steps,
285+
'instances' => message.web_instances,
286+
'memory' => message.memory_in_mb,
287+
'disk' => message.disk_in_mb,
288+
'log-rate' => message.log_rate_limit_in_bytes_per_second
290289
}
291290
)
292291
end

0 commit comments

Comments
 (0)