Skip to content

Commit 40fbbe2

Browse files
committed
skip tests which require unique constraint removal
1 parent d35a876 commit 40fbbe2

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

spec/unit/actions/service_credential_binding_app_create_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,9 @@ module V3
235235

236236
context 'when multiple bindings are allowed' do
237237
before do
238+
# TODO: Remove skip when the service bindings unique constraints are removed
238239
skip 'this test can be enabled when the service bindings unique constraints are removed and max_bindings_per_app_service_instance can be configured'
240+
239241
binding_1 = ServiceBinding.make(service_instance:, app:, name:)
240242
binding_2 = ServiceBinding.make(service_instance:, app:, name:)
241243
binding_1.save_with_attributes_and_new_operation({}, { type: 'create', state: 'succeeded' })

spec/unit/lib/cloud_controller/diego/service_binding_files_builder_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ module VCAP::CloudController::Diego
1818
end
1919

2020
context 'when there are multiple bindings with the same name for the same app and service instance' do
21+
before do
22+
# TODO: Remove skip when the service bindings unique constraints are removed
23+
skip 'this test can be enabled when the service bindings unique constraints are removed and max_bindings_per_app_service_instance can be configured'
24+
end
25+
2126
let(:newer_binding_created_at) { Time.now.utc - 2.minutes }
2227

2328
let!(:newer_binding) do

spec/unit/presenters/system_environment/system_env_presenter_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,11 @@ module VCAP::CloudController
131131
end
132132

133133
context 'when there are multiple service bindings for the same service instance' do
134+
before do
135+
# TODO: Remove skip when the service bindings unique constraints are removed
136+
skip 'this test can be enabled when the service bindings unique constraints are removed and max_bindings_per_app_service_instance can be configured'
137+
end
138+
134139
it 'includes only the latest binding' do
135140
newer_binding = ServiceBinding.make(app: app, service_instance: service_instance, syslog_drain_url: 'logs.go-here.com', created_at: Time.now.utc + 10.seconds)
136141

0 commit comments

Comments
 (0)