refac: ApiError is thrown in failed status during update

Author: serdarozerr

app/actions/v3/service_instance_update_managed.rb

@@ -113,7 +113,6 @@ def update(accepts_incomplete: false)
         end
       rescue StandardError => e
         save_failed_state(service_instance, e)
-
         raise e
       end
 
@@ -140,7 +139,7 @@ def poll
           raise LastOperationFailedState.new(details[:last_operation][:description])
         end
       rescue LastOperationFailedState => e
-        raise e
+        raise CloudController::Errors::ApiError.new_from_details('UnableToPerform', 'update', e.message)
       rescue StandardError => e
         save_failed_state(service_instance, e)
         raise e

spec/unit/actions/v3/service_instance_update_managed_spec.rb

@@ -1522,7 +1522,7 @@ module V3
           it 'raises and updates the last operation description' do
             expect do
               action.poll
-            end.to raise_error(VCAP::CloudController::V3::ServiceInstanceUpdateManaged::LastOperationFailedState)
+            end.to raise_error(CloudController::Errors::ApiError)
 
             expect(ServiceInstance.first.last_operation.type).to eq('update')
             expect(ServiceInstance.first.last_operation.state).to eq('failed')