chore(TNZ-44895): Validate max in flight and canary steps against the recreate strategy

Max in flight and canary steps are not valid options for the recreate deployment strategy

Author: PeteLevineA

app/messages/deployment_create_message.rb

@@ -26,7 +26,7 @@ class DeploymentCreateMessage < MetadataBaseMessage
 
     validates_with NoAdditionalKeysValidator
     validates :strategy,
-              inclusion: { in: %w[rolling canary], message: "'%<value>s' is not a supported deployment strategy" },
+              inclusion: { in: %w[rolling canary recreate], message: "'%<value>s' is not a supported deployment strategy" },
               allow_nil: true
     validate :mutually_exclusive_droplet_sources
 
@@ -113,6 +113,10 @@ def validate_scaling_options
 
     def validate_max_in_flight
       max_in_flight = options[:max_in_flight]
+      if max_in_flight && strategy == 'recreate'
+        errors.add(:'options.max_in_flight', 'is not a supported option for recreate deployment strategy')
+        return
+      end
 
       return unless !max_in_flight.is_a?(Integer) || max_in_flight < 1
 

spec/unit/messages/deployment_create_message_spec.rb

@@ -132,12 +132,16 @@ module VCAP::CloudController
           end
         end
 
-        context 'when set with recreate strategy'
+        context 'when set with recreate strategy' do
+          before do
+            body['options'] = { max_in_flight: 2 }
+          end
+
           it 'is not valid' do
             body['strategy'] = 'recreate'
             message = DeploymentCreateMessage.new(body)
             expect(message).not_to be_valid
-            expect(message.errors.full_messages).to include('Max in flight is not a supported option for recreate deployment strategy')
+            expect(message.errors.full_messages).to include('Options max in flight is not a supported option for recreate deployment strategy')
           end
         end
       end