feat: api error added to the service binding create/delete

Author: serdarozerr

app/actions/v3/service_binding_create.rb

@@ -53,7 +53,7 @@ def poll(binding)
           raise LastOperationFailedState
         end
       rescue LastOperationFailedState => e
-        raise e
+        raise CloudController::Errors::ApiError.new_from_details('UnableToPerform', 'create', e.message)
       rescue StandardError => e
         save_failed_state(binding, e)
         raise e

app/actions/v3/service_binding_delete.rb

@@ -60,7 +60,7 @@ def poll(binding)
           raise LastOperationFailedState
         end
       rescue LastOperationFailedState => e
-        raise e
+        raise CloudController::Errors::ApiError.new_from_details('UnableToPerform', 'delete', e.message)
       rescue StandardError => e
         update_last_operation(binding, state: 'failed', description: e.message)
         raise e

app/jobs/v3/create_binding_async_job.rb

@@ -66,6 +66,9 @@ def perform
         finish if polling_status[:finished]
 
         self.polling_interval_seconds = polling_status[:retry_after] if polling_status[:retry_after].present?
+      rescue CloudController::Errors::ApiError => e
+        save_failure(e.message)
+        raise e
       rescue OperationCancelled => e
         raise CloudController::Errors::ApiError.new_from_details('UnableToPerform', operation_type, e.message)
       rescue BindingNotFound => e

app/jobs/v3/delete_binding_job.rb

@@ -55,6 +55,9 @@ def perform
         return finish if polling_status[:finished]
 
         self.polling_interval_seconds = polling_status[:retry_after] if polling_status[:retry_after].present?
+      rescue CloudController::Errors::ApiError => e
+        save_failure(e.message)
+        raise e
       rescue StandardError => e
         save_failure(e.message) if binding.reload.last_operation.state != 'failed' && !e.is_a?(V3::ServiceRouteBindingDelete::ConcurrencyError)
         raise CloudController::Errors::ApiError.new_from_details('UnableToPerform', 'unbind', e.message)