Expire packages in packages_controller

Author: jochenehret

app/controllers/v3/packages_controller.rb

@@ -165,7 +165,9 @@ def create_fresh
       unprocessable_non_bits_package!
     end
 
-    PackageCreate.create(message:, user_audit_info:)
+    package = PackageCreate.create(message:, user_audit_info:)
+    BitsExpiration.new.expire_packages!(app)
+    package
   end
 
   def create_copy
@@ -182,11 +184,13 @@ def create_copy
     unauthorized! unless permission_queryer.can_write_to_active_space?(source_package.space.id)
     suspended! unless permission_queryer.is_space_active?(source_package.space.id)
 
-    PackageCopy.new.copy(
+    package = PackageCopy.new.copy(
       destination_app_guid: app_guid,
       source_package: source_package,
       user_audit_info: user_audit_info
     )
+    BitsExpiration.new.expire_packages!(destination_app)
+    package
   end
 
   def package_not_found!

lib/cloud_controller/packager/package_upload_handler.rb

@@ -21,8 +21,6 @@ def pack
         end
 
         package.succeed_upload!(checksums)
-
-        VCAP::CloudController::BitsExpiration.new.expire_packages!(package.app)
       ensure
         FileUtils.rm_f(@uploaded_files_path) if @uploaded_files_path
       end