Can't move routes to other orgs if the space has the same name as owner space#4341
Merged
philippthun merged 2 commits intocloudfoundry:mainfrom May 8, 2025
Merged
Conversation
…er space Compare the space id instead of name for route transfer
philippthun
reviewed
May 6, 2025
…er space Update spec
sethboyles
approved these changes
May 7, 2025
philippthun
approved these changes
May 8, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 8, 2025
Changes in cloud_controller_ng:
- Can't move routes to other orgs if the space has the same name as owner space
PR: cloudfoundry/cloud_controller_ng#4341
Author: Sriram Nookala <snookala@vmware.com>
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 8, 2025
Changes in cloud_controller_ng:
- Fix typo in sample response JSON in API docs
PR: cloudfoundry/cloud_controller_ng#4345
Author: Rashid Rashidov <rrashidov@gmail.com>
- Can't move routes to other orgs if the space has the same name as owner space
PR: cloudfoundry/cloud_controller_ng#4341
Author: Sriram Nookala <snookala@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare the space id instead of name for route transfer
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
Given org
org1with spacespaceorgorg2with spacespace:cf push dorawith no manifest (so default-route is used)cf move-route thawing.app-runtime-interfaces.ci.cloudfoundry.org --hostname dora -o org2 -s spacethis will return
OK, thinking the spaces are equal, though it wont actually be movedThe fix compares the space ids instead of the name so that the move-route actually works in this case.
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests