-
Notifications
You must be signed in to change notification settings - Fork 364
ADR: Use Bosh Storage CLIs for Blobstore Operations #4443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
provider: AzureRM | ||
max_package_size: 1610612736 | ||
``` | ||
* Parameters like `fog_connection` may be renamed after the transition period. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not define a "legacy fog_configuration" in an ADR but specify how such a configuration should really look like (of course, details can be worked out during implementation). Opt-in can easily be achieved by an ops file independent of the configuration format. Renaming bosh config parameters after a transition period is pain. Remember the experimental/temporary discussion for enabling Puma in cloudfoundry/capi-release#483.
Questions for the configuration:
blobstore_type
: genericstorage-cli
or specific types per IaaS (e.g.bosh-azure-storage-cli
)connection_config
(e.g. instead offog_connection
): generic (unvalidated) hash or blobstore type specific configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I specified the config changes in more detail
This repo is expected to contain the blobstore CLI's used in the BOSH ecosytem, at present these are: - https://github.com/cloudfoundry/bosh-azure-storage-cli - https://github.com/cloudfoundry/bosh-gcscli - https://github.com/cloudfoundry/bosh-s3cli - https://github.com/cloudfoundry/bosh-ali-storage-cli See also - cloudfoundry/cloud_controller_ng#4443
ADR to introduce support for the bosh storage CLIs as a replacement for fog.
Link for easy viewing