Conversation
… Draining for cc uploader is handled in cc uploader
jochenehret
approved these changes
Jul 18, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jul 18, 2025
Changes in cloud_controller_ng:
- Remove obsolete shutdown cc uploader function and corresponding test. Draining for cc uploader is handled in cc uploader
PR: cloudfoundry/cloud_controller_ng#4457
Author: Katharina Przybill <30441792+kathap@users.noreply.github.com>
moleske
deleted the
remove-obsolete-shutdown-cc-uploader-function-in-drain
branch
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draining for cc uploader will be handled in cc uploader. without dependency to CCNG.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
This function was originally part of an implementation to support draining in the CC uploader. However, the approach introduced a dependency on CCNG, which led to issues during deployments. Given the drawbacks of this design and the fact that it's no longer in use, we are now removing this obsolete code.
An explanation of the use cases your change solves
Remove obsolete code.
Links to any other associated PRs
Revert "Add draining for cc_uploader (#529)" capi-release#544
Add draining for cc_uploader #4351
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests