Improve Development Experience #4486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloThinksPi
force-pushed
the
fix-devcontainer
branch
5 times, most recently
from
1234d13 to
a5a4975
Compare
FloThinksPi
force-pushed
the
fix-devcontainer
branch
2 times, most recently
from
b3ca960 to
c458210
Compare
Since in a dev scenario we dont care about data loss we can speed up the tests majorly by running the DBs on a ramdisk. Also since the DB consumes CPU during the test its not good to start rspec executes equal to the number of CPU cores since the sume of load excedes that by a lot. So we leave 20% spare for the DB to have less CPU preemtive scheduling and all in all finish the rspecs faster. An environment variable was introduced PARALLEL_TEST_PROCESSORS_MULTIPLE that can be set to any floating point value and multiplies the CPU core count times PARALLEL_TEST_PROCESSORS_MULTIPLE. It defaults to 0.8 and rounds the CPU count up to the next integer so it cannot be less than 1 ever. Apply DB performance optimizations also for github actions
FloThinksPi
force-pushed
the
fix-devcontainer
branch
from
c458210 to
64310f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
This change repairs the devcontainer setup. For me it wasnt starting into a devcontainer anymore and i had to tweak some things. With this configuration im able to start a devcontainer successfully again.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests