Skip to content

Commit 3ab70a7

Browse files
authored
Merge pull request #679 from cloudfoundry/clarify_wg_area_promotions
Clarify how role promotion process works for WG Areas
2 parents 67c72bb + 3a7f684 commit 3ab70a7

File tree

1 file changed

+25
-28
lines changed

1 file changed

+25
-28
lines changed

toc/ROLES.md

Lines changed: 25 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -253,16 +253,11 @@ in.
253253

254254
A reviewer is an active contributor who wishes to formally work toward the approver role.
255255

256-
Reviewers can submit reviews of PRs within a working group area. They may also have PRs within a working group assigned to them.
256+
Reviewers can submit reviews of PRs within a Working Group Area. They may also have PRs within a working group assigned to them.
257257

258258
### Requirements
259259

260-
- Submission of a PR to the appropriate Working Group Charter that adds themselves to the team's yaml definition.
261-
262-
- Approval from two existing Approvers for that Working Group
263-
264-
- For Working Groups with fewer than 4 approvers, a single Approver review is sufficient.
265-
260+
- Actively contributing to the relevant Working Group Area(s).
266261

267262
### Responsibilities and privileges
268263

@@ -492,33 +487,34 @@ Last ammended by [RFC-0008 Role Change Process](https://github.com/cloudfoundry/
492487
they may submit a PR adding themselves to
493488
[contributors.yml](https://github.com/cloudfoundry/community/blob/main/org/contributors.yml).
494489

495-
- Two existing Contributors or Approvers must attest that they meet the criteria
496-
by reviewing the PR.
490+
- Two existing Contributors, Reviewers, or Approvers must attest that they meet
491+
the criteria by reviewing the PR.
497492

498-
- An existing Contributor or Approver may submit the promotion request on behalf of someone else, but they
499-
may not serve as a reviewer.
493+
- An existing Contributor, Reviewer, or Approver may submit the promotion
494+
request on behalf of someone else, but they may not serve as a reviewer.
500495

501496
- A Working Group Lead from any Working Group will merge or close the PR, based
502497
on the results of the review and their discretion.
503498

504499
- TOC members may bypass the review process and merge the PR at their
505500
discretion.
506501

507-
### Promotion to Approver
502+
### Promotion to Reviewer or Approver
508503

509-
- When a person meets the criteria to be an Approver for a Working Group as defined in
510-
[Approver Role](#approver),
511-
they may submit a PR to the appropriate Working Group Charter that adds
512-
themselves to the team's yaml definition.
504+
- When a person meets the criteria to be a Reviewer or Approver for a Working
505+
Group Area as defined in [Reviewer Role](#reviewer) or [Approver
506+
Role](#approver) respectively, they may submit a PR to the appropriate
507+
Working Group Charter that adds themselves to the team's yaml definition
508+
under the appropriate Area.
513509

514-
- Two existing Approvers for that Working Group must attest that they meet the criteria
515-
by reviewing the PR.
510+
- Two existing Approvers for that Working Group Area must attest that they meet
511+
the criteria by reviewing the PR.
516512

517-
- For Working Groups with fewer than 4 approvers, a single Approver review is
518-
sufficient.
513+
- For Working Group Areas with fewer than 4 Approvers, a single Approver review
514+
is sufficient.
519515

520-
- An existing Approver may submit the promotion request on behalf of someone else, but they
521-
may not serve as a reviewer.
516+
- An existing Approver may submit the promotion request on behalf of someone
517+
else, but they may not serve as a reviewer.
522518

523519
- A Working Group Lead for that Working Group will merge or close the PR, based
524520
on the results of the review and their discretion.
@@ -532,19 +528,20 @@ themselves to the team's yaml definition.
532528
removing the appropriate entry from
533529
[contributors.yml](https://github.com/cloudfoundry/community/blob/main/org/contributors.yml).
534530

535-
- An existing Contributor or Approver may submit the revocation request on
536-
behalf of someone else, but the person whose role is being revoked must be
537-
given two weeks to refute the revocation.
531+
- An existing Contributor, Reviewer, or Approver may submit the revocation
532+
request on behalf of someone else, but the person whose role is being revoked
533+
must be given two weeks to refute the revocation.
538534

539535
- A Working Group Lead from any Working Group will merge or close the PR, at
540536
their discretion and without review.
541537

542538
- TOC members may merge the PR at their discretion.
543539

544-
### Revoking Approver Role
540+
### Revoking Reviewer or Approver Role
545541

546-
- People with an Approver role may submit a PR to revoke their role by removing
547-
the appropriate entry from the yaml definition in their Working Group's charter.
542+
- People with a Reviewer or Approver role may submit a PR to revoke their role
543+
by removing the appropriate entry from the yaml definition in their Working
544+
Group's charter.
548545

549546
- An existing Approver may submit the revocation request on behalf of someone
550547
else, but the person whose role is being revoked must be given two weeks to

0 commit comments

Comments
 (0)