Skip to content

Conversation

@yishayh
Copy link

@yishayh yishayh commented Nov 19, 2025

A short explanation of the proposed change:
Extend the Sealights integration to support injection into any npm script command, not just npm start. This will enable support for commands like npm run start-dev, npm run dev, npm run server, etc.

An explanation of the use cases your change solves It will be possible to define run command for injection as npmRunScript parameter

VCAP_SERVICES
{
  "user-provided": [{
    "name": "sealights-service",
    "credentials": {
      "token": "xxx",
      "buildSessionId": "xxx",
      "npmRunScript": "start-dev"
    }
  }]
}

If it is not provided Sealight will be injected into start command for backward compatibility.

A short explanation of the proposed change:
Extend the Sealights integration to support injection into any npm script command, not just npm start. This will enable support for commands like npm run start-dev, npm run dev, npm run server, etc.

An explanation of the use cases your change solves
It will be possible to define run command for injection as npmRunScript parameter

VCAP_SERVICES
{
  "user-provided": [{
    "name": "sealights-service",
    "credentials": {
      "token": "xxx",
      "buildSessionId": "xxx",
      "npmRunScript": "start-dev"
    }
  }]
}
If it is not provided Sealight will be injected into start command for backward compatibility.
@linux-foundation-easycla
Copy link

CLA Not Signed

@ramonskie
Copy link

it seems you commited this with either the wrong name or you have not signed the cla yet (you can press the big red button) for signing

@yishayh
Copy link
Author

yishayh commented Nov 19, 2025

Thank @ramonskie , can you tell me who to enter as the CLA manager (For Tricentis)?

@ramonskie
Copy link

i would just put it on your personal account. as that would be the most easy

@yishayh
Copy link
Author

yishayh commented Nov 20, 2025

@ramonskie I'll need to approve it internally in Tricentis, I'll keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants