Test for additionalPrinterColumns used for ordering#4060
Merged
danail-branekov merged 1 commit intomainfrom Jul 4, 2025
Merged
Test for additionalPrinterColumns used for ordering#4060danail-branekov merged 1 commit intomainfrom
danail-branekov merged 1 commit intomainfrom
Conversation
- As we are using additionalPrinterColumns and the "get as table" feature of kubeapiserver we have to make sure that the table fields that we use for ordering are there and stay there. - This changes adds tests for all ordering fields of all currently implementd v3 resouces in Korifi as per the v3 spec - Some of the newly added fields are not yet used for ordering - Some existing fields were changed, minly display names - The "state" field of the cfapp resource is changed to desired state, because this is how it is defined in the spec issue #3701
danail-branekov
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3701
What is this change about?
implementd v3 resouces in Korifi as per the v3 spec
because this is how it is defined in the spec