Ensure test env stops successfully #4283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 72d2ec7 controllers tests have been failing on concourse CI with test env failing to stop during test tear down within its default timeout (30 seconds), for example https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-main/builds/1884 The issue is reproducible locally when running controller tests with 8 ginkgo nodes. Running them with 2 works fine May or may not be related to kubernetes-sigs/controller-runtime#1571 This commit replaces ``` Expect(testEnv.Stop()).To(Succeed()) ``` with ``` Eventually(testEnv.Stop, "1m").Should(Succeed()) ``` to ensure that test env stops successfully
danail-branekov
force-pushed
the
fix-failing-controllers-tests
branch
from
abe323e to
d7fe39f
Compare
uzabanov
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Since commit
72d2ec7
controllers tests have been failing on concourse CI with test env
failing to stop during test tear down within its default timeout (30 seconds),
for example https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-main/builds/1884
The issue is reproducible locally when running controller tests with 8
ginkgo nodes. Running them with 2 works fine
This commit replaces
with
to ensure that test env stops successfully
Tag your pair, your PM, and/or team
@georgethebeatle @uzabanov