You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Most of the change looks good to me.
Can you undo the changes you made in the releases directory though? We should not edit a pre-existing release after the fact, but instead cut a new release.
Also, do you want to add a minimum go version to the go.mod file? I'm not sure why it's currently missing that.
Can you undo the changes you made in the releases directory though? We should not edit a pre-existing release after the fact, but instead cut a new release.
1.7.1 will be the next release, somehow automated bot made this commit. Thats the reason I modified 1.7.1 yml file itself.
Also, do you want to add a minimum go version to the go.mod file? I'm not sure why it's currently missing that.
will do that
It is present at the bottom, not sure why
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.