Skip to content

Upgrading metric-store-release to GoLang v1.23.0#372

Merged
ssunka merged 6 commits intodevelopfrom
version-upgrades
Jun 6, 2025
Merged

Upgrading metric-store-release to GoLang v1.23.0#372
ssunka merged 6 commits intodevelopfrom
version-upgrades

Conversation

@ssunka
Copy link
Contributor

@ssunka ssunka commented May 7, 2025

No description provided.

Copy link
Member

@ctlong ctlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the change looks good to me.

Can you undo the changes you made in the releases directory though? We should not edit a pre-existing release after the fact, but instead cut a new release.

Also, do you want to add a minimum go version to the go.mod file? I'm not sure why it's currently missing that.

@ssunka
Copy link
Contributor Author

ssunka commented May 8, 2025

Most of the change looks good to me.

Can you undo the changes you made in the releases directory though? We should not edit a pre-existing release after the fact, but instead cut a new release.
1.7.1 will be the next release, somehow automated bot made this commit. Thats the reason I modified 1.7.1 yml file itself.
Also, do you want to add a minimum go version to the go.mod file? I'm not sure why it's currently missing that.
will do that
It is present at the bottom, not sure why

@ssunka ssunka force-pushed the version-upgrades branch from f14adb8 to 0f68393 Compare May 8, 2025 05:05
@ssunka ssunka requested a review from ctlong May 8, 2025 09:25
@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group May 8, 2025
@ssunka ssunka merged commit 63ffc02 into develop Jun 6, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Application Runtime Platform Working Group Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants