Merged
Conversation
Contributor
boyan-velinov
left a comment
boyan-velinov
left a comment
There was a problem hiding this comment.
Can we increase code coverage for the PR?
Now it is under the quality gate?
...eb/src/main/java/org/cloudfoundry/multiapps/controller/web/api/impl/FilesApiServiceImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| return triggerUploadFromUrl(spaceGuid, namespace, urlWithoutUserInfo, decodedUrl); | ||
| return triggerUploadFromUrl(spaceGuid, namespace, urlWithoutUserInfo, decodedUrl, fileUrl.getUserCredentials()); |
Contributor
There was a problem hiding this comment.
UserCredentials is passed through multiple layers just to reach buildFetchFileRequest. Just a small suggestion—consider encapsulating related parameters into a FileDownloadRequestContext to reduce method parameter lists and improve readability. Not a change request, just optimization proposal.
Yavor16
force-pushed
the
allow-special-characters-in-the-url
branch
from
f209ead to
adb20e2
Compare
boyan-velinov
approved these changes
Feb 25, 2025
boyan-velinov
previously approved these changes
Feb 25, 2025
...eb/src/main/java/org/cloudfoundry/multiapps/controller/web/api/impl/FilesApiServiceImpl.java
Outdated
Show resolved
Hide resolved
Yavor16
force-pushed
the
allow-special-characters-in-the-url
branch
2 times, most recently
from
f540504 to
dc7da2d
Compare
Yavor16
force-pushed
the
allow-special-characters-in-the-url
branch
from
dc7da2d to
6ba9a2f
Compare
|
boyan-velinov
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.