This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Fix ci build #266
Merged
Fix ci build #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been renamed upstream, so code directives need updating.
The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.
Highlighted by lint.
peanball
suggested changes
Nov 28, 2024
Contributor
|
some minor suggestions |
Add comments explaining why lint shouldn't warn.
peanball
approved these changes
Nov 28, 2024
Contributor
peanball
left a comment
peanball
left a comment
There was a problem hiding this comment.
looks good overall. approving for CI and we can merge if all of it passes :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using updated pcap-testflight image, bump ruby spec to match image version. Bump acceptance tests golang. Address issues highlighted by new lint version.
Changes can be viewed commit-by-commit for more focused/limited scope of modifications.