fix: Remove invalid HTTPS redirect test fixture #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonskie
reviewed
Jan 9, 2026
ivanovac
reviewed
Jan 9, 2026
ivanovac
reviewed
Jan 9, 2026
| Expect(cmd.Run()).To(Succeed()) | ||
| Eventually(func() string { | ||
| logs, _ := deployment.RuntimeLogs() | ||
| return logs.(string) |
There was a problem hiding this comment.
Please check this logs.(string) as logs variable returned from RuntimeLogs() already is a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Remove invalid HTTPS redirect test fixture and add platform-specific test handling
Delete fixtures/https_redirect/with_env/manifest.yml (was missing app configuration)
The manifest file only contained environment variables without an app definition,
causing 'Manifest must have at least one application' errors during cf push.
HTTPS redirect tests with environment variables will now be skipped on CF platform
until a proper fixture is created.
Add platform-aware skip to 'properly logs stdout and stderr' test
This test uses Docker commands directly (docker container logs) and is incompatible
with the CF platform. Added check for Docker platform before executing the test.
Improve it.After cleanup handler robustness
Made the cleanup handler conditional with !t.Skipped() check to prevent calling
platform.Delete on skipped tests, avoiding errors when trying to delete non-existent
deployment resources.