-
Notifications
You must be signed in to change notification settings - Fork 7
add github.com/prometheus/common/model to scraper to fix test #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chombium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alchen1218 thanks for updating the dependencies and fixing things.
We've taken a look at the problem with the test with @ZPascal and you also have to rebase the main branch into your fork. That will update the Prometheus common project which is used by the client_golang and will make the tests pass. The problem is that you don't have the updated dependencies in the vendor folder in your fork.
|
@chombium I checked out the repo without a fork; scripts/test failed if this change is not applied. This is due to the fact that on 9/18. there was a dependency bump, which changed prometheus/common from 0.65.0 to 0.66.1. The older TextParser is no longer supported in 0.66.1, it gives a compile error, thus requiring this change. With this change applied, tests succeeded. |
|
@alchen1218 Can you please rebase the branch to consume the updated |
chombium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
chombium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.