Skip to content

Conversation

@alchen1218
Copy link
Contributor

No description provided.

@alchen1218 alchen1218 requested a review from a team as a code owner September 18, 2025 06:18
Copy link
Contributor

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alchen1218 thanks for updating the dependencies and fixing things.

We've taken a look at the problem with the test with @ZPascal and you also have to rebase the main branch into your fork. That will update the Prometheus common project which is used by the client_golang and will make the tests pass. The problem is that you don't have the updated dependencies in the vendor folder in your fork.

@jorbaum jorbaum mentioned this pull request Sep 22, 2025
10 tasks
@weili-broadcom
Copy link

weili-broadcom commented Sep 26, 2025

@chombium I checked out the repo without a fork; scripts/test failed if this change is not applied. This is due to the fact that on 9/18. there was a dependency bump, which changed prometheus/common from 0.65.0 to 0.66.1. The older TextParser is no longer supported in 0.66.1, it gives a compile error, thus requiring this change. With this change applied, tests succeeded.

@ZPascal
Copy link

ZPascal commented Sep 26, 2025

@alchen1218 Can you please rebase the branch to consume the updated prometheus/common lib?

Copy link
Contributor

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group Sep 26, 2025
Copy link
Contributor

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chombium chombium merged commit cce0fcd into cloudfoundry:main Sep 26, 2025
3 of 4 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Application Runtime Platform Working Group Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants