Skip to content

Conversation

@SylwekLewan-dev
Copy link
Contributor

Purpose

  • This PR integrates with cf go-client changes that extend blue green deployment with additional monitoring of newly deployed application. The deployment will finished and considered successful when new application version reaches running state.

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 added the enhancement New feature or request label Dec 10, 2025
@lechnerc77 lechnerc77 added this to the 1.12.0 milestone Dec 10, 2025
@lechnerc77 lechnerc77 changed the title Feature/blue green deployment update feat: blue green deployment update Dec 10, 2025
@lechnerc77 lechnerc77 enabled auto-merge (squash) December 10, 2025 13:37
@lechnerc77 lechnerc77 disabled auto-merge December 10, 2025 13:37
@lechnerc77 lechnerc77 requested a review from Copilot December 10, 2025 13:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates blue-green deployment enhancements from the cf go-client library, adding configurable monitoring for newly deployed applications. The deployment is considered successful when the new application version reaches a running state within specified timeout and check interval parameters.

  • Adds app_deployed_running_timeout and app_deployed_running_check_interval attributes to configure deployment monitoring
  • Updates go-cfclient/v3 dependency to a pre-release version with extended blue-green deployment support
  • Refactors strategy handling to use dedicated methods for blue-green vs. other strategies

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Adds temporary replace directive for unreleased go-cfclient/v3 version with blue-green deployment enhancements
go.sum Updates checksums for the new go-cfclient/v3 pseudo-version
cloudfoundry/provider/types_app.go Adds AppDeployedRunningTimeout and AppDeployedRunningCheckInterval fields to AppType struct and includes them in CopyConfigAttributes
cloudfoundry/provider/resource_app.go Adds schema definitions, validators, and implementation logic for the new blue-green deployment configuration attributes
examples/resources/cloudfoundry_app/resource.tf Updates example to demonstrate usage of new blue-green deployment timeout and check interval attributes
docs/resources/app.md Documents the new optional attributes with their valid ranges and usage context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

This pull request is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale No activity on this issue label Jan 1, 2026
@vipinvkmenon vipinvkmenon removed the Stale No activity on this issue label Jan 1, 2026
},
},
"app_deployed_running_timeout": schema.Int64Attribute{
MarkdownDescription: "Timeout in minutes to wait for app to be running after updating deployment with 'blue-green' strategy. The default is 5 minutes. Min value is 1 minute. Used only when strategy is set to 'blue-green'.",
Copy link
Member

@vipinvkmenon vipinvkmenon Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SylwekLewan-dev The default value of 5 minutes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values are already defined in client: https://github.com/cloudfoundry/go-cfclient/pull/496/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added explicit constants in provider as well

@vipinvkmenon vipinvkmenon self-requested a review January 1, 2026 08:40
@lechnerc77
Copy link
Contributor

@SylwekLewan-dev your contribution to the goclient is part of the official release. Can you switch from the commit to the latest release in your PR?

@SylwekLewan-dev
Copy link
Contributor Author

Removed replace section from go.mod and synced to new go-cfclient

@lechnerc77 lechnerc77 merged commit f643501 into cloudfoundry:main Jan 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants