Improve Performance of LoginInfoEndpoint #3141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementing classes
…rDefinitionsForZone
adrianhoelzl-sap
force-pushed
the
improve-performance-of-login-info-endpoint
branch
from
f0b3408 to
df0a444
Compare
strehle
reviewed
Nov 19, 2024
...ain/java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthProviderConfigurator.java
Outdated
Show resolved
Hide resolved
...ain/java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthProviderConfigurator.java
Outdated
Show resolved
Hide resolved
...ain/java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthProviderConfigurator.java
Outdated
Show resolved
Hide resolved
strehle
approved these changes
Nov 21, 2024
duanemay
approved these changes
Nov 21, 2024
adrianhoelzl-sap
deleted the
improve-performance-of-login-info-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
SamlIdentityProviderConfigurator.getIdentityProviderDefinitionsForZone(called during the evaluation of a request to/login) returns the configurations of all SAML IdPs in an identity zone. Instead of specifying a condition on thetypecolumn of theidentity_providertable, it reads all (active) IdPs of the identity zone and filters them in the Java code.This PR fixes the lookup of SAML IdPs by moving the filtering for the SAML type to the query and introducing an index on the columns
identity_zone_id,activeandtypeof theidentity_providertable.