Fix regression with OIDC discovery url but no tokenUrl #3280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strehle
changed the title
Kehrlann
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causing Issue #3271
Withe the change from #3165 we improved performance because the loop of OIDC providers in /login endpoint should not request always all OIDC idps.
But now if you want use a concrete OIDC idp for password grant there could be the situation, that no tokenUrl is available
This PR checks if tokenUrl is null ( which is allowed from configuration ) and then fetch OIDC metadata. If the tokenUrl still is null, then exit with an error, but not run ino NPE.