Eliminate test setup on skipped tests #3690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes test execution by preventing unnecessary test setup for skipped tests in database migration integration tests. The change moves profile-based test skipping to occur earlier in the JUnit lifecycle.
- Changes
ProfileSelectionExtensionto useBeforeEachCallbackinstead ofBeforeTestExecutionCallback - Profile checking now happens before
@BeforeEachmethods execute, avoiding expensive setup operations like database cleaning when tests are skipped
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
adrianhoelzl-sap
approved these changes
Dec 4, 2025
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ProfileSelectionExtension to use BeforeEachCallback for JUnit tests instead of BeforeTestExecutionCallback
MySqlDbMigrationIntegrationTest, HsqlDbMigrationIntegrationTest, PostgresDbMigrationIntegrationTest were all doing test setup even when the tests were skipped.