Fix SCIM DateTime Filter Timezone Parsing #3700
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in UAA's SCIM DateTime filter implementation where ISO 8601 timestamps with timezone information were being parsed incorrectly, with the timezone being ignored and the JVM's local timezone being used instead.
Key Changes:
- Updated the SimpleDateFormat pattern in
getStringOrDate()method from'Z'(literal character) toX(ISO 8601 timezone pattern) - This allows proper parsing of timezone indicators like "Z" for UTC and "+HH:MM"/"-HH:MM" for timezone offsets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...r/src/main/java/org/cloudfoundry/identity/uaa/resources/jdbc/SimpleSearchQueryConverter.java
Show resolved
Hide resolved
strehle
approved these changes
Dec 11, 2025
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3699
This PR fixes a bug in UAA's SCIM filter implementation where ISO 8601 timestamps with timezone information were incorrectly parsed by ignoring the timezone and using the JVM's local timezone instead.
Changed the SimpleDateFormat pattern from
'Z'(literal character) toX(ISO 8601 timezone):'Z'in quotes treated as literal character → timezone information ignored, timestamp parsed in local timeXcorrectly interprets ISO 8601 timezone indicators (Z for UTC, +HH:MM/-HH:MM for offsets) → timestamp parsed with correct timezone