Skip to content

Conversation

@duanemay
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 15, 2025 14:27
strehle
strehle previously approved these changes Dec 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the CI testing infrastructure to support Java 25 and Ubuntu 24.04, expanding the test matrix to ensure compatibility with newer platform versions.

  • Updates the GitHub Actions workflow to run tests on Ubuntu 24.04 (from 22.04)
  • Adds Java 25 to the test matrix alongside the existing Java 21
  • Updates documentation to reflect Java 25 support

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
README.md Updated requirements section to document Java 25 support alongside Java 21
.github/workflows/gradle.yml Updated CI workflow to use Ubuntu 24.04 and test against both Java 21 and 25; improved comment clarity

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


Requirements:
* Java 21
* Java 21 or 25
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states Java 21 or 25 is required, but the build configuration in build.gradle (lines 50-51) enforces sourceCompatibility and targetCompatibility to VERSION_21 only. If Java 25 is intended to be supported, the build configuration should allow for both Java 21 and 25 compatibility, or the documentation should clarify that while Java 25 can run the application, the bytecode targets Java 21.

Suggested change
* Java 21 or 25
* Java 21 (required for building; application can be run on Java 21 or 25, but bytecode targets Java 21)

Copilot uses AI. Check for mistakes.
@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Dec 15, 2025
@duanemay duanemay merged commit 463a9ee into develop Dec 15, 2025
34 of 35 checks passed
@duanemay duanemay deleted the testjava25 branch December 15, 2025 16:56
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants