Open
Conversation
lhardt
commented
Feb 6, 2026
| <meta name="viewport" content="width=device-width, initial-scale=1.0"/> | ||
| <link href="/vendor/font-awesome/css/font-awesome.min.css" th:href="@{/vendor/font-awesome/css/font-awesome.min.css}" rel="stylesheet"/> | ||
| <link href="/resources/oss/stylesheets/application.css" th:href="@{${assetBaseUrl}+'/stylesheets/application.css'}" rel="stylesheet"/> | ||
| <link href="/resources/oss/stylesheets/application.min.css" th:href="@{${assetBaseUrl}+'/stylesheets/application.min.css'}" rel="stylesheet"/> |
Author
There was a problem hiding this comment.
I'm not sure here if I understand this line's usage correctly.
If the host provides external branding and provides their on assetBaseUrl, do we expect all the /resources/oss contents to be present there or do we expect the host to provide their own custom application.css?
A remote possibility is, if the host created their own application.css (but not a minified version) this would ensure the css file is not found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr
application.cssapplication.css(112529 bytes , compared to the original's 235830 bytes, a ~50% reduction).longer version
This PR is intended to expand on #1414 , by minifying the CSS file. Instead of minifying the CSS file directly, I preserved the original one, and created an
application.min.cssfile. For the record, I used this minification tool.Inspecting a little further, It also seems to me that the
application.cssfile composed of:It is essentially overkill, accumulated from another project, when this login-server commit stripped away Sass from the build process and merged all CSS files into what today is
application.css. Finally, it ended up here after the contents of login-served were merged into this repo.The lack of attribution when squashing all Sass might be concerning, and is a possible license violation of the abovementioned CSS libraries. I removed a sizeable part of the "bootstrappy" code that appeared to be unused, as well as
gravatarrelated classes, which could mitigate library risk.