[p2p] cbfmgr: improve error on cbfmgr #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudhead
reviewed
Apr 15, 2022
Collaborator
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
I think also that InvalidRange is a better error in this case!
vincenzopalazzo
requested changes
Apr 16, 2022
Return error early if filter header isn't downloaded for requested filter
Collaborator
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
IMHO this is still good, there is not reason to keep this pending.
It is possible rebase it? While we wait the @cloudhead point of view?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return error early if filter header isn't downloaded for requested filter