Updated to more correct relationship#523
Open
isaac-s wants to merge 1 commit intocloudify-cosmo:masterfrom
Open
Updated to more correct relationship#523isaac-s wants to merge 1 commit intocloudify-cosmo:masterfrom
isaac-s wants to merge 1 commit intocloudify-cosmo:masterfrom
Conversation
At runtime, it doesn't matter whether the port is `connected_to` the network or `contained_in`, because the code looks for any kind of a relationship. So the original code works. However, it serves as a bad example because this relationship between a port and a network is *incorrect*. Among other things, a `contained_in` relationship between a port and a network would prevent the user from using scaling groups to include a Server and a Port in the same scaling group; that wouldn't pass validation, because `Port` would be `contained_in` a network and thus `Server` and `Port` have an ancestry conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At runtime, it doesn't matter whether the port is
connected_tothe network orcontained_in, because the code looks for any kind of a relationship. So the original code works. However, it serves as a bad example because this relationship between a port and a network is incorrect. Among other things, acontained_inrelationship between a port and a network would prevent the user from using scaling groups to include a Server and a Port in the same scaling group; that wouldn't pass validation, becausePortwould becontained_ina network and thusServerandPorthave an ancestry conflict.