fix: update dependencies #746
Conversation
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| elem = document.querySelector(`#${cssEscape(id)}`) || videojs.getPlayer(id); | ||
| } catch (e) { | ||
| } catch (err) { // eslint-disable-line no-unused-vars | ||
| elem = null; |
There was a problem hiding this comment.
I would console.warn the error instead of the eslint disable line ... since anyway we have other console.warn statements .... later we need to start thinking how we should report these errors somewhere
src/utils/attributes-normalizer.js
Outdated
| try { | ||
| val = JSON.parse(string); | ||
| } catch (e) { | ||
| } catch (e) { // eslint-disable-line no-unused-vars |
There was a problem hiding this comment.
I would console.warn the error instead of the eslint disable line ... since anyway we have other console.warn statements .... later we need to start thinking how we should report these errors somewhere
There was a problem hiding this comment.
In principle I agree, but it seems like in this case the author used try...catch to silence the failing JSON.parse()
I'll try thinking of a better way to write this
fix: update dependencies (#746) feat: light esm build (#765) --------- Co-authored-by: Tsachi Shlidor <[email protected]> Co-authored-by: ShayLevi <[email protected]> Co-authored-by: cloudinary-jenkins <[email protected]>
No description provided.